Fix CI: bump Node 16 → 20 in deploy workflow#306
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/shadowsocks/shadowsocks-org/sessions/72fefb45-1a60-4fea-8596-9c3bada96d88 Co-authored-by: madeye <627917+madeye@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
madeye
April 14, 2026 10:08
View session
There was a problem hiding this comment.
Pull request overview
Updates the deploy workflow to run on Node.js 20 to restore CI compatibility with newer Vite/Vue tooling.
Changes:
- Bump deploy workflow Node.js version from 16 to 20.
- Upgrade GitHub Actions versions (
actions/checkoutandactions/setup-node) to@v4. - Enable Yarn dependency caching and remove the unnecessary Node version matrix.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
11
to
13
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v4 | ||
| with: |
There was a problem hiding this comment.
The steps list is not indented under steps: (the - uses: line is aligned with steps:), which makes this workflow invalid YAML and will prevent the job from running. Indent the list items (and their nested keys) under steps: (e.g., match the indentation used in .github/workflows/ci.yml).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm-grunt.ymlwas pinned to Node 16, which is incompatible with@vitejs/plugin-vue ≥5.x(Expected version "^18.0.0 || >=20.0.0"), causing every push tomainto fail atyarn install.Changes
npm-grunt.yml: Replace Node 16 matrix with Node 20; upgradeactions/checkout@v2→@v4andactions/setup-node@v1→@v4(with yarn cache); remove now-unnecessarystrategy.matrix